Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go-yaml to v3 #954

Closed
wants to merge 1 commit into from
Closed

update go-yaml to v3 #954

wants to merge 1 commit into from

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Sep 8, 2019

No description provided.

@umarcor umarcor mentioned this pull request Sep 11, 2019
Closed
@jharshman
Copy link
Collaborator

@umarcor is there a reason for the update?
PR descriptions should never be blank.

@jharshman jharshman self-requested a review October 2, 2019 03:34
@umarcor
Copy link
Contributor Author

umarcor commented Oct 2, 2019 •
edited
Loading

@jharshman, there is no special reason, but the preference to slowly keep up to date, instead of having large conflicts afterwards. That's why there is no description. Unlike #953, this is just a chore.

BTW, spf13/pflag v1.0.5 was released two weeks ago. I didn't open a PR yet, because of the maintenance status.

Note that this type of PRs would be automatically created by dependabot (#907), should it be enabled for this repo.

umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
update viper, pflag and yaml (spf13#953) (spf13#954)
60fa963
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
update viper, pflag and yaml (spf13#953) (spf13#954)
4804cd6
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 2, 2019
@umarcor
update viper, pflag and yaml (spf13#953) (spf13#954)
78b0ce3
@jharshman
Copy link
Collaborator

That's why there is no description. Unlike #953, this is just a chore.

PR descriptions should never be blank, even for a "chore". This causes maintainers to guess why this PR has been opened. i.e: bug fixes? new feature?

@jharshman
Copy link
Collaborator

Looks like they have not tagged a v3.0.0 release yet.
Gonna hold off on upgrading for the time being.
go-yaml/yaml#487

@jharshman jharshman closed this Oct 3, 2019
@umarcor umarcor deleted the update-yaml branch October 3, 2019 18:56
@umarcor
Copy link
Contributor Author

umarcor commented Oct 3, 2019

Sure. There is also v2.2.3. I could update the PR accordingly.

Nevertheless, I think that #953 is prioritary. By the time we have other prioritary PRs merged, there might be a tagged v3.0.0 for go-yaml.

@umarcor umarcor mentioned this pull request Oct 9, 2019
Merged
umarcor added a commit to umarcor/cobra that referenced this pull request Oct 14, 2019
@umarcor
update viper, pflag and yaml (spf13#953) (spf13#954)
5b83b0a
@umarcor umarcor mentioned this pull request Jan 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharshman jharshman Awaiting requested review from jharshman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umarcor @jharshman